]> git.ipfire.org Git - thirdparty/suricata.git/commit
datasets: remove useless NULL check 13483/head
authorEric Leblond <el@stamus-networks.com>
Mon, 16 Jun 2025 09:23:43 +0000 (11:23 +0200)
committerVictor Julien <victor@inliniac.net>
Wed, 18 Jun 2025 16:22:59 +0000 (18:22 +0200)
commit495a12fad720137253de23313821e3ca81884cbc
tree37ba7306cfed92eb7e7ac62bf4c0e97a63f3d1e1
parente947c4030caa71f09b42763d19dc17807e7bc2c5
datasets: remove useless NULL check

Coverity did detect that the cleaning code is only reached with
Dataset *set being initialized so the check is useless.

** CID 1649392:       Null pointer dereferences  (REVERSE_INULL)
/src/datasets-context-json.c: 719           in DatajsonGet()
>>>     Null-checking "set" suggests that it may be null, but it has
already been dereferenced on all paths leading to the check.

** CID 1649391:       Null pointer dereferences  (REVERSE_INULL)
/src/datasets.c: 526           in DatasetGet()
>>>     Null-checking "set" suggests that it may be null, but it has
already been dereferenced on all paths leading to the check.
src/datasets-context-json.c
src/datasets.c