]> git.ipfire.org Git - thirdparty/pdns.git/commit
dnsdist: syslog should be enabled by default 14331/head
authorOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 8 Apr 2024 11:14:21 +0000 (13:14 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 17 Jun 2024 08:40:11 +0000 (10:40 +0200)
commit14fa0c730a641ab4dfbe77d0051b3aa530e01ecd
tree3e03e243b4edf7a58fbf3d68ec88d6ff92a970d5
parent14a3de88f7a235812d65a43d5756dd59820c6b6e
dnsdist: syslog should be enabled by default

Regression introduced with the logging refactoring of dnsdist.

In rel/dnsdist-1.8.x: https://github.com/PowerDNS/pdns/blob/4d5bb67a2a75f9d88894e7dfc42bbbebfda297b0/pdns/dnsdist.cc#L103 :

bool g_syslog{true};

In master and 1.9.x the newly intrdoduced LoggingConfiguration::s_syslog
is inited to false.

This does not matter using the default systemd unit file as it disables syslog:

ExecStart=@bindir@/dnsdist --supervised --disable-syslog

but it does matter for non-systemd cases.

(cherry picked from commit 22931f35e56ff2c0b5e2147c157a5a765d60b8a2)
pdns/dnsdistdist/dolog.cc