]> git.ipfire.org Git - thirdparty/bootstrap.git/commit
generalize dropdowns / drop role="menu" 16571/head
authorPatrick H. Lauke <redux@splintered.co.uk>
Tue, 2 Jun 2015 08:41:40 +0000 (09:41 +0100)
committerPatrick H. Lauke <redux@splintered.co.uk>
Tue, 2 Jun 2015 10:03:21 +0000 (11:03 +0100)
commit5fd7bc1554d492bdd5794d35fce515fe951439a6
tree61ac7cd8243c6d6c4c6e8de4b373132b01419df7
parent3b59b97c626bf2accef8217339b04712666c36d9
generalize dropdowns / drop role="menu"

as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria)
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
21 files changed:
docs/_includes/components/button-dropdowns.html
docs/_includes/components/button-groups.html
docs/_includes/components/dropdowns.html
docs/_includes/components/input-groups.html
docs/_includes/components/navbar.html
docs/_includes/components/navs.html
docs/_includes/js/dropdowns.html
docs/_includes/js/scrollspy.html
docs/_includes/js/tabs.html
docs/examples/carousel/index.html
docs/examples/navbar-fixed-top/index.html
docs/examples/navbar-static-top/index.html
docs/examples/navbar/index.html
docs/examples/non-responsive/index.html
docs/examples/sticky-footer-navbar/index.html
docs/examples/theme/index.html
js/dropdown.js
js/tests/unit/dropdown.js
js/tests/visual/dropdown.html
js/tests/visual/scrollspy.html
js/tests/visual/tab.html