]> git.ipfire.org Git - thirdparty/pdns.git/commit
auth: fix geoip_mmdb backend MMDB_open error handling 16669/head
authorEnsar Sarajčić <dev@ensarsarajcic.com>
Fri, 19 Dec 2025 12:57:06 +0000 (13:57 +0100)
committerEnsar Sarajčić <dev@ensarsarajcic.com>
Fri, 19 Dec 2025 12:57:06 +0000 (13:57 +0100)
commite1641d3872c48f4ec1ed11b775b5318322f2184a
tree9b17a76643e466711a5f94fafe883d951dfc0c5d
parent6f7d47fd7a90381dcb583ce430d4c8f894e70753
auth: fix geoip_mmdb backend MMDB_open error handling

According to [MMDB_open docs], errors from `MMDB_open` should be
compared to `MMDB_SUCCESS` (which is 0). All other errors are > 0, which
means that existing check never detects errors, causing further queries
to fail with error:
```
The MaxMind DB file is in a format this library can't handle
(unknown record size or binary format version)
```

[MMDB_open docs]: https://maxmind.github.io/libmaxminddb/#mmdb_open

Signed-off-by: Ensar Sarajčić <dev@ensarsarajcic.com>
modules/geoipbackend/geoipinterface-mmdb.cc