]> git.ipfire.org Git - thirdparty/vectorscan.git/commit
Correct set_source_files_properties usage 189/head
authorMitchell Wasson <miwasson@cisco.com>
Tue, 31 Oct 2023 15:09:48 +0000 (09:09 -0600)
committerMitchell Wasson <miwasson@cisco.com>
Tue, 31 Oct 2023 15:35:50 +0000 (09:35 -0600)
commit9c139c3a6d2df77ae2eb3973265aec869cc71017
tree82fefca731507c8f86053d3494d2fdaa04d03524
parentde94286fed6c65057a922d7236d7e8304278ac54
Correct set_source_files_properties usage

The use of `CMAKE_BINARY_DIR` and `CMAKE_CURRENT_BINARY_DIR` when
specifying files to set_source_files_properties caused problems
when this project is used from another CMake project.

More specifically, these variables aren't set to the expected path,
and the properties are attempted to be set for non-existant files.

This was benign before vectorscan 5.4.8 as the only properties
set were warning suppression flags.

Starting with 5.4.9, `-funsigned-char` was applied to Ragel outputs
using this method. The result is projects depending on Vectorscan
through Cmake do not have this compile flag properly applied.
CMakeLists.txt
tools/hscollider/CMakeLists.txt
util/CMakeLists.txt