]> git.ipfire.org Git - thirdparty/openwrt.git/commit
tools: automake: fix MAINTAINERCLEANFILES warnings 19593/head
authorMichael Pratt <mcpratt@pm.me>
Tue, 29 Jul 2025 17:56:10 +0000 (13:56 -0400)
committerRobert Marko <robimarko@gmail.com>
Tue, 29 Jul 2025 19:31:11 +0000 (21:31 +0200)
commitdddf7b05cded37514be383fc3119b7277d410a33
treef351dc5cb6f307389fc17796388624279809de96
parent9c26d144893c25e484ca97c7a3f58cdec6767465
tools: automake: fix MAINTAINERCLEANFILES warnings

It seems that, for whatever reason in this case,
the function "vardef ($var, $cond)" does not work
while "$var->def ($cond)" does work for conditionals.

Also, do not define it conditionally when defined unconditionally.
Even though the reordering patch would make that functionally sound,
it still throws a warning which can cause a build to fail
when warnings are treated as errors.

Instead, just add BUILT_SOURCES to every existing case
rather than only when BUILT_SOURCES is defined.

Fixes: 6d2bfe50d3 ("tools/automake: control all cleaning with clean variables")
Signed-off-by: Michael Pratt <mcpratt@pm.me>
Link: https://github.com/openwrt/openwrt/pull/19593
Signed-off-by: Robert Marko <robimarko@gmail.com>
tools/automake/patches/310-maintainer-clean-built_sources.patch