]> git.ipfire.org Git - thirdparty/suricata.git/commit
hyperscan: fix minor coverity warning 1358023 1970/head
authorVictor Julien <victor@inliniac.net>
Thu, 31 Mar 2016 08:07:01 +0000 (10:07 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 31 Mar 2016 08:07:01 +0000 (10:07 +0200)
commitba035e601e6f5d56a9ce2c5bbb4bb2c2c80d2eca
tree7311c1d6ba80ee0d4a5dcd742c588255bdc872ad
parent2ccf028eac9ed88fe16a6f7d473ae97c4062732a
hyperscan: fix minor coverity warning 1358023

*** CID 1358023:  Null pointer dereferences  (REVERSE_INULL)
/src/util-mpm-hs.c: 860 in SCHSDestroyThreadCtx()
854         if (thr_ctx->scratch != NULL) {
855             hs_free_scratch(thr_ctx->scratch);
856             mpm_thread_ctx->memory_cnt--;
857             mpm_thread_ctx->memory_size -= thr_ctx->scratch_size;
858         }
859
>>>     CID 1358023:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "mpm_thread_ctx->ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
860         if (mpm_thread_ctx->ctx != NULL) {
861             SCFree(mpm_thread_ctx->ctx);
862             mpm_thread_ctx->ctx = NULL;
863             mpm_thread_ctx->memory_cnt--;
864             mpm_thread_ctx->memory_size -= sizeof(SCHSThreadCtx);
865         }
src/util-mpm-hs.c