]> git.ipfire.org Git - thirdparty/systemd.git/commit
test: correctly mask supporting services in tests 19990/head
authorFrantisek Sumsal <frantisek@sumsal.cz>
Tue, 22 Jun 2021 10:30:24 +0000 (12:30 +0200)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Tue, 22 Jun 2021 10:34:31 +0000 (12:34 +0200)
commit179ca4d2b1b5579014773a128462475f99b7a91b
treed31ed92303f332ecbd24cf877b13c77ed85d1169
parent907300c3c3db0940964dd511f9744529226a69a2
test: correctly mask supporting services in tests

It turns out the "supporting services" were run in _all_ tests if
TEST-01-BASIC was run as the first test (which is usually the case),
since with the original condition in test_create_image() we would skip
the masking and then propagate the change to the default image used by
other tests. This has been causing multiple bogus test timeouts
(especially when the hwdb was being rebuilt in tests with short
timeouts, like TEST-52-HONORFIRSTSHUTDOWN).

Let's "fix" this by making the call to mask_supporting_services()
uncoditional and override the test_create_image() function in
TEST-01-BASIC to avoid the masking in this single case.
test/TEST-01-BASIC/test.sh
test/test-functions