]> git.ipfire.org Git - thirdparty/suricata-update.git/commit
(Remote)Code-Execution while loading yaml-file 23/head
authorWolfgang Hotwagner <sec@feedyourhead.at>
Wed, 13 Dec 2017 20:53:34 +0000 (20:53 +0000)
committerWolfgang Hotwagner <sec@feedyourhead.at>
Wed, 13 Dec 2017 20:53:34 +0000 (20:53 +0000)
commit76270e73128ca1299b4e33e7e2a74ac3d963a97a
treef96b736f8e39a6bf959951e2ad3d9848b49dd869
parent8b47847bde22a4e29513ecf168c83bc7074600d8
(Remote)Code-Execution while loading yaml-file

The list of possible sources for suricata-update is downloaded from "https://www.openinfosecfoundation.org/rules/index.yaml" per default. Suricata-Update uses the insecure yaml.load()-function. Code will be executed if the yaml-file contains lines like:

hello: !!python/object/apply:os.system ['ls -l > /tmp/output']

The vulnerable function can be triggered by "suricata-update list-sources". The locally stored index.yaml will be loaded in this function and the malicious code gets executed.

This commit fixes Bug #2359
suricata/update/config.py
suricata/update/sources.py