]> git.ipfire.org Git - thirdparty/zstd.git/commit
projects / thirdparty / zstd.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 52598d5) | patch
[binary-tree] Fix underflow of nbCompares 2820/head
authorNick Terrell <terrelln@fb.com>
Fri, 8 Oct 2021 18:45:30 +0000 (11:45 -0700)
committerNick Terrell <terrelln@fb.com>
Fri, 8 Oct 2021 20:22:55 +0000 (13:22 -0700)
commitc6c482fe07fb4f0e5007641ed9f6b758900c93c1
treef701ca80eeb74209fad254ee815234606849c8c3tree | snapshot
parent52598d54e98d1de87a8e89c7fc0aa1bfc9b67e16commit | diff
[binary-tree] Fix underflow of nbCompares

Fix underflow of `nbCompares` by switching to an `int` and comparing
`nbCompares > 0`. This is a minimal fix, because I don't want to change
the logic. These loops seem to be doing `nbCompares + 1` comparisons.

The bug was reported by Dan Carpenter and found by Smatch static
checker.

https://lore.kernel.org/all/20211008063704.GA5370@kili/
lib/compress/zstd_lazy.c diff | blob | blame | history
lib/compress/zstd_opt.c diff | blob | blame | history
tests/regression/results.csv diff | blob | blame | history
Mirror of https://github.com/facebook/zstd.git