]> git.ipfire.org Git - thirdparty/systemd.git/commit
timesync: fix PropertiesChanges signals for NTP properties 29915/head
authorFrantisek Sumsal <frantisek@sumsal.cz>
Tue, 7 Nov 2023 12:16:05 +0000 (13:16 +0100)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Tue, 7 Nov 2023 20:36:59 +0000 (21:36 +0100)
commit9521574cd4c8c21dfc654020a8d6de561b24bd82
tree202ca9ea7ea86e280b711cf327fb372d60089e29
parent41e4ce06fe2de1ad0321c4636577460de2271e36
timesync: fix PropertiesChanges signals for NTP properties

As in their current form they didn't work at all:

systemd-timesyncd[190115]: Assertion 's' failed at src/libsystemd/sd-event/sd-event.c:3058, function sd_event_source_set_enabled(). Ignoring.
systemd-timesyncd[190115]: Failed to reenable system ntp server change event source!
systemd-timesyncd[190115]: Failed to enable ntp server defer event, ignoring: Invalid argument

This was also pointed out in the post-merge review [0].

Let's address this together with the rest of the comments, and add
some tests to make sure everything works as it should.

Resolves: #28770
Follow-up to: 8f1c446

[0] https://github.com/systemd/systemd/commit/8f1c4469793f2f0281fdfbc20ba4085e20cdd16f#r124147466
src/timesync/timesyncd-manager.c
src/timesync/timesyncd-server.c
test/units/testsuite-45.sh