]> git.ipfire.org Git - thirdparty/zstd.git/commit
Trigger Release Artifact Generation on Publish 3018/head
authorW. Felix Handte <w@felixhandte.com>
Thu, 20 Jan 2022 22:36:28 +0000 (17:36 -0500)
committerW. Felix Handte <w@felixhandte.com>
Thu, 20 Jan 2022 22:36:28 +0000 (17:36 -0500)
commitfa9cb4510ac26cdad607e19c72133e4c4961b189
treebfe70eebf84f50516a1c4fc1baab6bb0aa78b19e
parenta8f1aa2f6d747b4cea8dd1df5e60769757150528
Trigger Release Artifact Generation on Publish

We previously triggered release artifact generation on release creation. We
sometimes observed that the action failed to run. I hypothesized that we were
hitting rate limiting or something. I just stumbled across [this documentat-
ion](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release), which says:

> Note: Workflows are not triggered for the `created`, `edited`, or `deleted`
> activity types for draft releases. When you create your release through the
> GitHub browser UI, your release may automatically be saved as a draft.

This must have been what was happening. This commit therefore changes the
trigger to the `published` activity. This should be more reliable.

This does have the unfortunate side effect that artifacts won't be generated
or attached until *after* the release has been published, which is what I was
trying to avoid by using the `created` activity. Oh well.
.github/workflows/publish-release-artifacts.yml