]> git.ipfire.org Git - thirdparty/zstd.git/commit
Fix duplicate LC_RPATH error on MacOS 4370/head 4371/head
authorEtienne Cordonnier <ecordonnier@snap.com>
Fri, 18 Apr 2025 12:37:50 +0000 (14:37 +0200)
committerEtienne Cordonnier <ecordonnier@snap.com>
Fri, 18 Apr 2025 13:59:06 +0000 (15:59 +0200)
commit8929d3b09f7391b4756dd5056fded3a6a90bc9a4
tree2e4067e7176e735dd34e88bb23d563a910176353
parentd654fca78690fa15cceb8058ac47454d914a0e63
Fix duplicate LC_RPATH error on MacOS

After the update to MacOS 15.4, the dynamic loader dyld treats duplicated LC_RPATH as an error.
The `FLAGS` variable already contains `LDFLAGS`, thus using both `FLAGS` and `LDFLAGS`
duplicates all `LDFLAGS`, including `-Wl,rpath` parameters.

The duplicate LC_RPATH causes this kind of errors:

```
dyld[29361]: Library not loaded: @loader_path/../lib/libzstd.1.dylib
      Referenced from: <7131C877-3CF0-33AC-AA05-257BA4FDD770> /Users/foobar/...
      Reason: tried: '/Users/foobar/..../lib/libzstd.1.dylib' (duplicate LC_RPATH '/usr/mypath.../lib')
```

Closes https://github.com/facebook/zstd/issues/4369

Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
lib/Makefile