]> git.ipfire.org Git - thirdparty/systemd.git/commit
units: add system-update-cleanup.service to guard against offline-update loops 4763/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 29 Nov 2016 06:29:02 +0000 (01:29 -0500)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 29 Nov 2016 06:40:34 +0000 (01:40 -0500)
commit953bf4604f5ce02d1bd8abb09e82ea80e101c8a3
treed9ae2a086fd16fae4da49e5cfe10d09d0db03f85
parent2b656050b624312a472cc5df6870999745bd8ad5
units: add system-update-cleanup.service to guard against offline-update loops

Note: the name is "system-update-cleanup.service" rather than
"system-update-done.service", because it should not run normally, and also
because there's already "systemd-update-done.service", and having them named
so similarly would be confusing.

In https://bugzilla.redhat.com/show_bug.cgi?id=1395686 the system repeatedly
entered system-update.target on boot. Because of a packaging issue, the tool
that created the /system-update symlink could be installed without the service
unit that was supposed to perform the upgrade (and remove the symlink). In
fact, if there are no units in system-update.target, and /system-update symlink
is created, systemd always "hangs" in system-update.target. This is confusing
for users, because there's no feedback what is happening, and fixing this
requires starting an emergency shell somehow, and also knowing that the symlink
must be removed. We should be more resilient in this case, and remove the
symlink automatically ourselves, if there are no upgrade service to handle it.

This adds a service which is started after system-update.target is reached and
the symlink still exists. It nukes the symlink and reboots the machine. It
should subsequently boot into the default default.target.

This is a more general fix for
https://bugzilla.redhat.com/show_bug.cgi?id=1395686 (the packaging issue was
already fixed).
Makefile.am
man/systemd.offline-updates.xml
man/systemd.special.xml
units/.gitignore
units/system-update-cleanup.service.in [new file with mode: 0644]
units/system-update.target