]> git.ipfire.org Git - thirdparty/suricata.git/commit
flow-timeout: change error logic 795/head
authorVictor Julien <victor@inliniac.net>
Fri, 24 Jan 2014 17:09:46 +0000 (18:09 +0100)
committerVictor Julien <victor@inliniac.net>
Mon, 27 Jan 2014 11:46:27 +0000 (12:46 +0100)
commitef40fe1f31a0e7644ffe9f0154df07ff027f37f8
tree1c47779d2eb7f78d997660a30ba161268feced0a
parentad7eff555de898e7abcdbf89fdbe9a4806bb72b6
flow-timeout: change error logic

If FlowForceReassemblyForFlowV2 can't get packets to inject into the
engine, until now it would bail and retry later. In case of resource
starvation issues, this would cause a lot of lock contention, as the
flow manager would try over and over again.

This patch limits FlowForceReassemblyForFlowV2 to one try per flow,
if it fails... bad luck. It will only fail in serious conditions,
which means we must prefer the health of the engine over the proper
inspection of the flow in question.
src/flow-timeout.c