]> git.ipfire.org Git - thirdparty/pdns.git/commit
rec: fix two coverity issues 8256/head
authorOtto Moerbeek <otto.moerbeek@open-xchange.com>
Fri, 30 Aug 2019 08:36:59 +0000 (10:36 +0200)
committerOtto Moerbeek <otto.moerbeek@open-xchange.com>
Fri, 30 Aug 2019 08:36:59 +0000 (10:36 +0200)
commita73da04b6350a0b15ee974990d34fc783d5446dd
tree41f33138fd223edb1b2a79e3d3ea48b6ad63068e
parenta0d790f71783059d991447a97fce58277f4cc0cf
rec: fix two coverity issues

1. Uninitialized field in DNSComboWriter.
2. TOCTOU wrt stat() and then opendir(). opendir() already tells us if the path
is not a dir or not accesible, so no need to do a TOCTOU sensitive pre-check.
Use uniform error messages in log and exceptions while here.
pdns/arguments.cc
pdns/pdns_recursor.cc