]> git.ipfire.org Git - thirdparty/suricata.git/commit
detect: SigMatchAppendSMToList can fail 9853/head
authorPhilippe Antoine <pantoine@oisf.net>
Thu, 7 Sep 2023 09:00:42 +0000 (11:00 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 21 Nov 2023 05:47:36 +0000 (06:47 +0100)
commitc272a646c5ae739d18901776cc5a940afd3d3d38
treed248df150747b69ccd8a292f4e90fb7348006044
parente38b9de6a2fe8ca53f19585f84b24ae31ee720c9
detect: SigMatchAppendSMToList can fail

Ticket: #6104

And failures should be handled to say that the rule failed to load

Reverts the fix by 299ee6ed5561f01575150b436d5db31485dab146
that was simple, but not complete (memory leak),
to have this bigger API change which simplifies code.
106 files changed:
src/detect-app-layer-event.c
src/detect-app-layer-protocol.c
src/detect-asn1.c
src/detect-base64-decode.c
src/detect-bsize.c
src/detect-bypass.c
src/detect-byte-extract.c
src/detect-bytejump.c
src/detect-bytemath.c
src/detect-bytetest.c
src/detect-cipservice.c
src/detect-config.c
src/detect-content.c
src/detect-csum.c
src/detect-datarep.c
src/detect-dataset.c
src/detect-dce-iface.c
src/detect-dce-opnum.c
src/detect-detection-filter.c
src/detect-dhcp-leasetime.c
src/detect-dhcp-rebinding-time.c
src/detect-dhcp-renewal-time.c
src/detect-dnp3.c
src/detect-dns-opcode.c
src/detect-dsize.c
src/detect-engine-event.c
src/detect-file-hash-common.c
src/detect-filesize.c
src/detect-filestore.c
src/detect-flow-age.c
src/detect-flow-pkts.c
src/detect-flow.c
src/detect-flowbits.c
src/detect-flowint.c
src/detect-flowvar.c
src/detect-fragbits.c
src/detect-fragoffset.c
src/detect-ftpbounce.c
src/detect-ftpdata.c
src/detect-geoip.c
src/detect-hostbits.c
src/detect-http2.c
src/detect-icmp-id.c
src/detect-icmp-seq.c
src/detect-icmpv6-mtu.c
src/detect-icode.c
src/detect-id.c
src/detect-ike-chosen-sa.c
src/detect-ike-exch-type.c
src/detect-ike-key-exchange-payload-length.c
src/detect-ike-nonce-payload-length.c
src/detect-ipopts.c
src/detect-ipproto.c
src/detect-iprep.c
src/detect-isdataat.c
src/detect-itype.c
src/detect-krb5-errcode.c
src/detect-krb5-msgtype.c
src/detect-krb5-ticket-encryption.c
src/detect-lua.c
src/detect-mark.c
src/detect-modbus.c
src/detect-mqtt-connack-sessionpresent.c
src/detect-mqtt-connect-flags.c
src/detect-mqtt-flags.c
src/detect-mqtt-protocol-version.c
src/detect-mqtt-qos.c
src/detect-mqtt-reason-code.c
src/detect-mqtt-type.c
src/detect-nfs-procedure.c
src/detect-nfs-version.c
src/detect-parse.c
src/detect-parse.h
src/detect-pcre.c
src/detect-pktvar.c
src/detect-replace.c
src/detect-rfb-secresult.c
src/detect-rfb-sectype.c
src/detect-rpc.c
src/detect-sameip.c
src/detect-snmp-pdu_type.c
src/detect-snmp-version.c
src/detect-ssh-proto-version.c
src/detect-ssh-software-version.c
src/detect-ssl-state.c
src/detect-ssl-version.c
src/detect-stream_size.c
src/detect-tag.c
src/detect-tcp-ack.c
src/detect-tcp-flags.c
src/detect-tcp-seq.c
src/detect-tcp-window.c
src/detect-tcpmss.c
src/detect-template.c
src/detect-template2.c
src/detect-threshold.c
src/detect-tls-cert-validity.c
src/detect-tls-certs.c
src/detect-tls-version.c
src/detect-tls.c
src/detect-tos.c
src/detect-ttl.c
src/detect-urilen.c
src/detect-xbits.c
src/detect.h
src/util-threshold-config.c