]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't advance origin during apply failure. REL_16_STABLE github/REL_16_STABLE
authorAmit Kapila <akapila@postgresql.org>
Wed, 24 Dec 2025 03:53:42 +0000 (03:53 +0000)
committerAmit Kapila <akapila@postgresql.org>
Wed, 24 Dec 2025 04:19:57 +0000 (04:19 +0000)
commit63a65adf4d8ea85ad9870fdce9351f73be00e26d
tree975f1304e2b1dce91eeb200e44cdf6d697bc2559
parent7efef18ffc14af2399bce34d40850b410dd1fe8d
Don't advance origin during apply failure.

The logical replication parallel apply worker could incorrectly advance
the origin progress during an error or failed apply. This behavior risks
transaction loss because such transactions will not be resent by the
server.

Commit 3f28b2fcac addressed a similar issue for both the apply worker and
the table sync worker by registering a before_shmem_exit callback to reset
origin information. This prevents the worker from advancing the origin
during transaction abortion on shutdown. This patch applies the same fix
to the parallel apply worker, ensuring consistent behavior across all
worker types.

As with 3f28b2fcac, we are backpatching through version 16, since parallel
apply mode was introduced there and the issue only occurs when changes are
applied before the transaction end record (COMMIT or ABORT) is received.

Author: Hou Zhijie <houzj.fnst@fujitsu.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 16
Discussion: https://postgr.es/m/TY4PR01MB169078771FB31B395AB496A6B94B4A@TY4PR01MB16907.jpnprd01.prod.outlook.com
Discussion: https://postgr.es/m/TYAPR01MB5692FAC23BE40C69DA8ED4AFF5B92@TYAPR01MB5692.jpnprd01.prod.outlook.com
src/backend/replication/logical/worker.c
src/test/subscription/t/023_twophase_stream.pl