lei_mail_sync: fix size check for Maildir||MH files

`-s $fh' returns undef only when a file is non-existent and zero
when it's empty.  Thus so we must use `||' to skip empty files.
Furthermore, `-s FILEHANDLE' is never undef on open handles.

Fixes: 5aab49f3 (lei: support reading MH for convert+import+index, 2023-12-29)

diff --git a/lib/PublicInbox/LeiMailSync.pm b/lib/PublicInbox/LeiMailSync.pm
index cab5bbb3814c4fd9b2e782288fd424e5f86872c4..5bd5fb48db94e73ebb48ea2df312beae08d94480 100644 (file)
--- a/lib/PublicInbox/LeiMailSync.pm
+++ b/lib/PublicInbox/LeiMailSync.pm
@@ -460,7 +460,7 @@ WHERE b.oidbin = ?
                        my $f = "$d/$x/$n";
                        open my $fh, '<', $f or next;
                        # some (buggy) Maildir writers are non-atomic:
                        my $f = "$d/$x/$n";
                        open my $fh, '<', $f or next;
                        # some (buggy) Maildir writers are non-atomic:

-                       my $raw = read_all($fh, -s $fh // next);
+                       my $raw = read_all($fh, -s $fh || next);

                        next if $vrfy && blob_mismatch $f, $oidhex, \$raw;
                        return \$raw;
                }
                        next if $vrfy && blob_mismatch $f, $oidhex, \$raw;
                        return \$raw;
                }


@@ -478,7 +478,7 @@ WHERE b.oidbin = ? AND f.loc REGEXP '^mh:/'
                $f =~ s/\Amh://s or die "BUG: not MH: $f";
                $f .= "/$n";
                open my $fh, '<', $f or next;
                $f =~ s/\Amh://s or die "BUG: not MH: $f";
                $f .= "/$n";
                open my $fh, '<', $f or next;

-               my $raw = read_all($fh, -s $fh // next);
+               my $raw = read_all($fh, -s $fh || next);

                next if blob_mismatch $f, $oidhex, \$raw;
                return \$raw;
        }
                next if blob_mismatch $f, $oidhex, \$raw;
                return \$raw;
        }