qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth

[ Upstream commit 130f634da1af649205f4a3dd86cbe5c126b57914 ]

Function qtnf_event_handle_external_auth calls memcpy without
checking the length.
A user could control that length and trigger a buffer overflow.
Fix by checking the length is within the maximum allowed size.

Signed-off-by: Lee Gibson <leegib@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210419145842.345787-1-leegib@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/wireless/quantenna/qtnfmac/event.c b/drivers/net/wireless/quantenna/qtnfmac/event.c
index c775c177933b2a8b597507a945f93b4dbead9397..8dc80574d08d9fd9b722b1ac58478b463ddb6ef8 100644 (file)
--- a/drivers/net/wireless/quantenna/qtnfmac/event.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/event.c
@@ -570,8 +570,10 @@ qtnf_event_handle_external_auth(struct qtnf_vif *vif,
                return 0;
 
        if (ev->ssid_len) {
-               memcpy(auth.ssid.ssid, ev->ssid, ev->ssid_len);
-               auth.ssid.ssid_len = ev->ssid_len;
+               int len = clamp_val(ev->ssid_len, 0, IEEE80211_MAX_SSID_LEN);
+
+               memcpy(auth.ssid.ssid, ev->ssid, len);
+               auth.ssid.ssid_len = len;
        }
 
        auth.key_mgmt_suite = le32_to_cpu(ev->akm_suite);