]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
devlink: Fix incorrect skb socket family dumping
authorLi RongQing <lirongqing@baidu.com>
Tue, 7 Apr 2026 02:27:30 +0000 (22:27 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 9 Apr 2026 02:34:38 +0000 (19:34 -0700)
The devlink_fmsg_dump_skb function was incorrectly using the socket
type (sk->sk_type) instead of the socket family (sk->sk_family)
when filling the "family" field in the fast message dump.

This patch fixes this to properly display the socket family.

Fixes: 3dbfde7f6bc7b8 ("devlink: add devlink_fmsg_dump_skb() function")
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Link: https://patch.msgid.link/20260407022730.2393-1-lirongqing@baidu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/devlink/health.c

index 449c7611c640f1d9428e1104467ce1de04528442..ea7a334e939b577e136fee5005bdd9a542aecbac 100644 (file)
@@ -1327,7 +1327,7 @@ void devlink_fmsg_dump_skb(struct devlink_fmsg *fmsg, const struct sk_buff *skb)
        if (sk) {
                devlink_fmsg_pair_nest_start(fmsg, "sk");
                devlink_fmsg_obj_nest_start(fmsg);
-               devlink_fmsg_put(fmsg, "family", sk->sk_type);
+               devlink_fmsg_put(fmsg, "family", sk->sk_family);
                devlink_fmsg_put(fmsg, "type", sk->sk_type);
                devlink_fmsg_put(fmsg, "proto", sk->sk_protocol);
                devlink_fmsg_obj_nest_end(fmsg);