]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
Clarify skip test message in test_doq.py (#952)
authorScott Kitterman <sklist@kitterman.com>
Sat, 8 Jul 2023 20:02:31 +0000 (16:02 -0400)
committerGitHub <noreply@github.com>
Sat, 8 Jul 2023 20:02:31 +0000 (13:02 -0700)
While the current message is technically correct, nanoquic isn't actually what's missing, so it would be clearer to point to the fact that aioquic isn't found, since that's the issue someone can actually do something about.

tests/test_doq.py

index 254b578ed2f8cbfbecb11914272ea3990b9bb80c..7d48bc22c002acb0630b68baba89a4f7624225aa 100644 (file)
@@ -24,7 +24,7 @@ except ImportError:
         pass
 
 
-@pytest.mark.skipif(not _nanoquic_available, reason="requires nanoquic")
+@pytest.mark.skipif(not _nanoquic_available, reason="requires aioquic")
 def test_basic_sync():
     with Server() as server:
         q = dns.message.make_query("www.example.", "A")
@@ -38,7 +38,7 @@ async def amain():
     assert r.rcode() == dns.rcode.REFUSED
 
 
-@pytest.mark.skipif(not _nanoquic_available, reason="requires nanoquic")
+@pytest.mark.skipif(not _nanoquic_available, reason="requires aioquic")
 def test_basic_asyncio():
     dns.asyncbackend.set_default_backend("asyncio")
     with Server() as server:
@@ -48,7 +48,7 @@ def test_basic_asyncio():
 try:
     import trio
 
-    @pytest.mark.skipif(not _nanoquic_available, reason="requires nanoquic")
+    @pytest.mark.skipif(not _nanoquic_available, reason="requires aioquic")
     def test_basic_trio():
         dns.asyncbackend.set_default_backend("trio")
         with Server() as server: