]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: hda: cs35l56: Fix signedness error in cs35l56_hda_posture_put()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 26 Feb 2026 11:17:28 +0000 (11:17 +0000)
committerTakashi Iwai <tiwai@suse.de>
Thu, 26 Feb 2026 11:42:59 +0000 (12:42 +0100)
In cs35l56_hda_posture_put() assign ucontrol->value.integer.value[0] to
a long instead of an unsigned long. ucontrol->value.integer.value[0] is
a long.

This fixes the sparse warning:

sound/hda/codecs/side-codecs/cs35l56_hda.c:256:20: warning: unsigned value
that used to be signed checked against zero?
sound/hda/codecs/side-codecs/cs35l56_hda.c:252:29: signed value source

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 73cfbfa9caea8 ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Link: https://patch.msgid.link/20260226111728.1700431-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/codecs/side-codecs/cs35l56_hda.c

index cfc8de2ae499aa7bbf215664945c6f485b67bb28..eb66827eabf8b856c549d3e12aa387c6d26b08b5 100644 (file)
@@ -249,7 +249,7 @@ static int cs35l56_hda_posture_put(struct snd_kcontrol *kcontrol,
                                   struct snd_ctl_elem_value *ucontrol)
 {
        struct cs35l56_hda *cs35l56 = snd_kcontrol_chip(kcontrol);
-       unsigned long pos = ucontrol->value.integer.value[0];
+       long pos = ucontrol->value.integer.value[0];
        bool changed;
        int ret;