Bug 277073: Make whining trap errors thrown by Search.pm

r=wicked a=LpSolit

diff --git a/template/en/default/global/messages.html.tmpl b/template/en/default/global/messages.html.tmpl
index cad4758e26d5526406062c407cc2c5658138d07f..52502a1d75cdfbf392655e14e7147d0325955265 100644 (file)
--- a/template/en/default/global/messages.html.tmpl
+++ b/template/en/default/global/messages.html.tmpl
@@ -829,6 +829,10 @@
       No changes made to version <em>[% version.name FILTER html %]</em>.
     [% END %]
 
+  [% ELSIF message_tag == "whine_query_failed" %]
+    The query '[% query_name FILTER html %]' from [% author.login FILTER html %]
+    failed: [% reason FILTER html %]
+
   [% ELSIF message_tag == "workflow_updated" %]
     The workflow has been updated.
   [% END %]

diff --git a/whine.pl b/whine.pl
index 1f22b65fc4fffd9acd7c472e2b1abd14859e2bb4..12ad9a0e0c497d2e5dac3dd3e15a2e69e15eb5f4 100755 (executable)
--- a/whine.pl
+++ b/whine.pl
@@ -444,11 +444,17 @@ sub run_queries {
         # Bugzilla::Search to execute a saved query.  It's exceedingly weird,
         # but that's how it works.
         my $searchparams = new Bugzilla::CGI($savedquery);
-        my $search = new Bugzilla::Search(
+        my $search = eval { new Bugzilla::Search(
             'fields' => \@searchfields,
             'params' => $searchparams,
             'user'   => $args->{'recipient'}, # the search runs as the recipient
-        );
+        ) };
+        if ($@) {
+            print STDERR get_text('whine_query_failed', { query_name => $thisquery->{'name'},
+                                                          author => $args->{'author'},
+                                                          reason => $@ }) . "\n";
+            next;
+        }
         my $sqlquery = $search->getSQL();
         $sth = $dbh->prepare($sqlquery);
         $sth->execute;