]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuMonitorGetAllBlockStatsInfo: Assign hash table only on success
authorTim Wiederhake <twiederh@redhat.com>
Tue, 6 Jul 2021 12:37:51 +0000 (14:37 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 13 Jul 2021 12:40:28 +0000 (14:40 +0200)
`virHashNew` cannot return NULL, the check is not needed.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_monitor.c

index 19fcc5658beedc0a990a71693ec9a7c6233bf2d0..d24531832b4404139a0b8cb8e2c924020ea0e286 100644 (file)
@@ -2155,22 +2155,24 @@ qemuMonitorGetAllBlockStatsInfo(qemuMonitor *mon,
                                 bool backingChain)
 {
     int ret;
+    GHashTable *stats = NULL;
     VIR_DEBUG("ret_stats=%p, backing=%d", ret_stats, backingChain);
 
     QEMU_CHECK_MONITOR(mon);
 
-    if (!(*ret_stats = virHashNew(g_free)))
+    if (!(stats = virHashNew(g_free)))
         goto error;
 
-    ret = qemuMonitorJSONGetAllBlockStatsInfo(mon, *ret_stats, backingChain);
+    ret = qemuMonitorJSONGetAllBlockStatsInfo(mon, stats, backingChain);
 
     if (ret < 0)
         goto error;
 
+    *ret_stats = stats;
     return ret;
 
  error:
-    virHashFree(*ret_stats);
+    virHashFree(stats);
     *ret_stats = NULL;
     return -1;
 }