]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: ak4458: remove the reset operation in probe and remove
authorShengjiu Wang <shengjiu.wang@nxp.com>
Tue, 16 Dec 2025 07:02:01 +0000 (15:02 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 17 Dec 2025 12:01:00 +0000 (12:01 +0000)
The reset_control handler has the reference count for usage, as there is
reset operation in runtime suspend and resume, then reset operation in
probe() would cause the reference count of reset not balanced.

Previously add reset operation in probe and remove is to fix the compile
issue with !CONFIG_PM, as the driver has been update to use
RUNTIME_PM_OPS(), so that change can be reverted.

Fixes: 1e0dff741b0a ("ASoC: ak4458: remove "reset-gpios" property handler")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Link: https://patch.msgid.link/20251216070201.358477-1-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/ak4458.c

index 783d2ef21c11c1b3a4d451dffce7901db82a19f1..f81cd8cebdd8988cd0382a66404de56c88a0630c 100644 (file)
@@ -783,16 +783,12 @@ static int ak4458_i2c_probe(struct i2c_client *i2c)
 
        pm_runtime_enable(&i2c->dev);
        regcache_cache_only(ak4458->regmap, true);
-       ak4458_reset(ak4458, false);
 
        return 0;
 }
 
 static void ak4458_i2c_remove(struct i2c_client *i2c)
 {
-       struct ak4458_priv *ak4458 = i2c_get_clientdata(i2c);
-
-       ak4458_reset(ak4458, true);
        pm_runtime_disable(&i2c->dev);
 }