]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mm: mm_init: use div64_ul() instead of do_div()
authorGiorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Tue, 2 Jun 2026 11:32:45 +0000 (15:32 +0400)
committerMike Rapoport (Microsoft) <rppt@kernel.org>
Tue, 2 Jun 2026 13:10:31 +0000 (16:10 +0300)
Fixes Coccinelle/coccicheck warning reported by do_div.cocci.

Compared to do_div(), div64_ul() does not implicitly cast the divisor and
does not unnecessarily calculate the remainder.

There are no functional changes. The benefit is purely a semantic cleanup
that better communicates the intent of the division and resolves the
static analysis warning.

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Link: https://patch.msgid.link/20260602-mm-div64-cleanup-v1-1-bf5d67d89d93@gmail.com
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
mm/mm_init.c

index f9f8e1af921cda91d812cffdad2f1a0698cfd6ac..4e0909a721d227b097653ed6aaa019960a7c3383 100644 (file)
@@ -2412,7 +2412,7 @@ void *__init alloc_large_system_hash(const char *tablename,
        /* limit allocation size to 1/16 total memory by default */
        if (max == 0) {
                max = ((unsigned long long)nr_all_pages << PAGE_SHIFT) >> 4;
-               do_div(max, bucketsize);
+               max = div64_ul(max, bucketsize);
        }
        max = min(max, 0x80000000ULL);