Revert "Fix lock handling in memory hander of nscd."

This reverts commit 137028b4d7e50f71906c1656c27079eac5a1d085.

Conflicts:

	ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 6418f866f49fe3b555452659f2d98f2d0c199690..dce8cbc232982242fb93634885b3c54932137e38 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,17 +4,6 @@
        * resolv/res-mkquery.c (__res_nopt): If anslen is > 0xffff store
        0xffff in the EDNS0 record.
 
-2009-07-16  Petr Baudis  <pasky@suse.cz>
-
-       [BZ #10402]
-       * nscd/mem.c (mempool_alloc): Fix unlock missing in the else branch.
-       * nscd/aicache.c: Remove bogus db->lock unlock.
-       * nscd/grpcache.c: Likewise.
-       * nscd/hstcache.c: Likewise.
-       * nscd/initgrcache.c: Likewise.
-       * nscd/pwdcache.c: Likewise.
-       * nscd/servicescache.c: Likewise.
-
 2009-07-16  Ulrich Drepper  <drepper@redhat.com>
 
        * nscd/cache.c (cache_add): Use atomic_compare_and_exchange_bool_rel

diff --git a/nscd/aicache.c b/nscd/aicache.c
index 8dac48e5c2fa35d6f5c4469edb34a0cdeddc8ee2..524c0a63af0080fc50a3b56830ef13b1d7a808be 100644 (file)
--- a/nscd/aicache.c
+++ b/nscd/aicache.c
@@ -543,6 +543,8 @@ next_nip:
       (void) cache_add (req->type, key_copy, req->key_len, &dataset->head,
                        true, db, uid, he == NULL);
 
+      pthread_rwlock_unlock (&db->lock);
+
       /* Mark the old entry as obsolete.  */
       if (dh != NULL)
        dh->usable = false;

diff --git a/nscd/grpcache.c b/nscd/grpcache.c
index fc2008449ea38fd593dd2026c073ed5fbf20fd77..184d53898ca371f3ab8a90f3cecc53e855c1683c 100644 (file)
--- a/nscd/grpcache.c
+++ b/nscd/grpcache.c
@@ -146,6 +146,8 @@ cache_addgr (struct database_dyn *db, int fd, request_header *req,
              (void) cache_add (req->type, &dataset->strdata, req->key_len,
                                &dataset->head, true, db, owner, he == NULL);
 
+             pthread_rwlock_unlock (&db->lock);
+
              /* Mark the old entry as obsolete.  */
              if (dh != NULL)
                dh->usable = false;
@@ -365,10 +367,12 @@ cache_addgr (struct database_dyn *db, int fd, request_header *req,
                (void) cache_add (GETGRBYGID, cp, key_offset, &dataset->head,
                                  false, db, owner, false);
            }
+
+       out:
+         pthread_rwlock_unlock (&db->lock);
        }
     }
 
-out:
   if (__builtin_expect (written != total, 0) && debug_level > 0)
     {
       char buf[256];

diff --git a/nscd/hstcache.c b/nscd/hstcache.c
index 77ffcdf8801fbd9ba3143d454f43c04b7c765341..51e2273960e728359531da5b5bf327bbfc33b7cf 100644 (file)
--- a/nscd/hstcache.c
+++ b/nscd/hstcache.c
@@ -153,6 +153,8 @@ cache_addhst (struct database_dyn *db, int fd, request_header *req,
              (void) cache_add (req->type, &dataset->strdata, req->key_len,
                                &dataset->head, true, db, owner, he == NULL);
 
+             pthread_rwlock_unlock (&db->lock);
+
              /* Mark the old entry as obsolete.  */
              if (dh != NULL)
                dh->usable = false;
@@ -402,6 +404,8 @@ cache_addhst (struct database_dyn *db, int fd, request_header *req,
 
          (void) cache_add (req->type, key_copy, req->key_len,
                            &dataset->head, true, db, owner, he == NULL);
+
+         pthread_rwlock_unlock (&db->lock);
        }
     }
 

diff --git a/nscd/initgrcache.c b/nscd/initgrcache.c
index f8d4742d166936cd10de5a5b68f75f2ecd0e5cd8..c33aaf315f7df1eb0a5bd58ea70edfa68283149f 100644 (file)
--- a/nscd/initgrcache.c
+++ b/nscd/initgrcache.c
@@ -230,6 +230,8 @@ addinitgroupsX (struct database_dyn *db, int fd, request_header *req,
              (void) cache_add (req->type, key_copy, req->key_len,
                                &dataset->head, true, db, uid, he == NULL);
 
+             pthread_rwlock_unlock (&db->lock);
+
              /* Mark the old entry as obsolete.  */
              if (dh != NULL)
                dh->usable = false;
@@ -386,6 +388,8 @@ addinitgroupsX (struct database_dyn *db, int fd, request_header *req,
 
          (void) cache_add (INITGROUPS, cp, req->key_len, &dataset->head, true,
                            db, uid, he == NULL);
+
+         pthread_rwlock_unlock (&db->lock);
        }
     }
 

diff --git a/nscd/mem.c b/nscd/mem.c
index 80ea9511467681496724cac585910086490452d4..fcea6dbd03c7ad22ce7a6c874b2e152a0afbd4ff 100644 (file)
--- a/nscd/mem.c
+++ b/nscd/mem.c
@@ -566,6 +566,9 @@ mempool_alloc (struct database_dyn *db, size_t len, int data_alloc)
            }
        }
 
+      if (data_alloc)
+       pthread_rwlock_unlock (&db->lock);
+
       if (! db->last_alloc_failed)
        {
          dbg_log (_("no more memory for database '%s'"), dbnames[db - dbs]);
@@ -588,8 +591,5 @@ mempool_alloc (struct database_dyn *db, size_t len, int data_alloc)
 
   pthread_mutex_unlock (&db->memlock);
 
-  if (data_alloc)
-    pthread_rwlock_unlock (&db->lock);
-
   return res;
 }

diff --git a/nscd/pwdcache.c b/nscd/pwdcache.c
index fc5b44eef0e775e83b7c048150cb2b0ddefbe3b8..2338e7e1e089c1e62052a48bce0d53efd77c60c8 100644 (file)
--- a/nscd/pwdcache.c
+++ b/nscd/pwdcache.c
@@ -153,6 +153,8 @@ cache_addpw (struct database_dyn *db, int fd, request_header *req,
              (void) cache_add (req->type, key_copy, req->key_len,
                                &dataset->head, true, db, owner, he == NULL);
 
+             pthread_rwlock_unlock (&db->lock);
+
              /* Mark the old entry as obsolete.  */
              if (dh != NULL)
                dh->usable = false;
@@ -360,10 +362,12 @@ cache_addpw (struct database_dyn *db, int fd, request_header *req,
                (void) cache_add (GETPWBYUID, cp, key_offset, &dataset->head,
                                  false, db, owner, false);
            }
+
+       out:
+         pthread_rwlock_unlock (&db->lock);
        }
     }
 
-out:
   if (__builtin_expect (written != total, 0) && debug_level > 0)
     {
       char buf[256];

diff --git a/nscd/servicescache.c b/nscd/servicescache.c
index c965c972a39f77e986df80baca446fca18c859c2..dc98d3005ade8d4dae0ab95c26fd544f86d73f6f 100644 (file)
--- a/nscd/servicescache.c
+++ b/nscd/servicescache.c
@@ -136,6 +136,8 @@ cache_addserv (struct database_dyn *db, int fd, request_header *req,
              (void) cache_add (req->type, &dataset->strdata, req->key_len,
                                &dataset->head, true, db, owner, he == NULL);
 
+             pthread_rwlock_unlock (&db->lock);
+
              /* Mark the old entry as obsolete.  */
              if (dh != NULL)
                dh->usable = false;
@@ -315,6 +317,8 @@ cache_addserv (struct database_dyn *db, int fd, request_header *req,
 
          (void) cache_add (req->type, key_copy, req->key_len,
                            &dataset->head, true, db, owner, he == NULL);
+
+         pthread_rwlock_unlock (&db->lock);
        }
     }