]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
HID: bigbenff: constify fixed up report descriptor
authorThomas Weißschuh <linux@weissschuh.net>
Wed, 28 Aug 2024 07:33:20 +0000 (09:33 +0200)
committerBenjamin Tissoires <bentiss@kernel.org>
Thu, 5 Sep 2024 14:20:56 +0000 (16:20 +0200)
Now that the HID core can handle const report descriptors,
constify them where possible.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20240828-hid-const-fixup-2-v1-1-663b9210eb69@weissschuh.net
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-bigbenff.c

index a2ff60dd834c894cf96c7d871a8b34477a004ddc..9f05465358d9f1878aa215cae9dfbbb6863ceef0 100644 (file)
@@ -99,7 +99,7 @@
  * - map previously unused analog trigger data to Z/RZ
  * - simplify feature and output descriptor
  */
-static __u8 pid0902_rdesc_fixed[] = {
+static const __u8 pid0902_rdesc_fixed[] = {
        0x05, 0x01,        /* Usage Page (Generic Desktop Ctrls) */
        0x09, 0x05,        /* Usage (Game Pad) */
        0xA1, 0x01,        /* Collection (Application) */
@@ -468,8 +468,8 @@ static const __u8 *bigben_report_fixup(struct hid_device *hid, __u8 *rdesc,
        unsigned int *rsize)
 {
        if (*rsize == PID0902_RDESC_ORIG_SIZE) {
-               rdesc = pid0902_rdesc_fixed;
                *rsize = sizeof(pid0902_rdesc_fixed);
+               return pid0902_rdesc_fixed;
        } else
                hid_warn(hid, "unexpected rdesc, please submit for review\n");
        return rdesc;