]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
hwmon: (ltc4282) Fix reading the minimum alarm voltage
authorGuenter Roeck <linux@roeck-us.net>
Wed, 5 Feb 2025 20:27:15 +0000 (12:27 -0800)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 27 Jul 2026 18:34:24 +0000 (11:34 -0700)
Coverity reports an out-of-bounds access when reading the minimum alarm
voltage for the VGPIO channel. Add the missing return statement to fix
the problem.

Fixes: cbc29538dbf7 ("hwmon: Add driver for LTC4282")
Cc: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ltc4282.c

index 39b9d3abca990b3df6b59337d7c8c0a072093008..cc698803f8bf8bd853fbe0284a77a16b20d7f05b 100644 (file)
@@ -374,8 +374,8 @@ static int ltc4282_read_in(struct ltc4282_state *st, u32 attr, long *val,
                                                   channel, val);
        case hwmon_in_min_alarm:
                if (channel == LTC4282_CHAN_VGPIO)
-                       ltc4282_read_alarm(st, LTC4282_ADC_ALERT_LOG,
-                                          LTC4282_GPIO_ALARM_L_MASK, val);
+                       return ltc4282_read_alarm(st, LTC4282_ADC_ALERT_LOG,
+                                                 LTC4282_GPIO_ALARM_L_MASK, val);
 
                return ltc4282_vdd_source_read_alm(st,
                                                   LTC4282_VSOURCE_ALARM_L_MASK,