]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ice: Fix incorrect timeout ice_release_res()
authorDing Hui <dinghui@sangfor.com.cn>
Sat, 6 Dec 2025 13:46:09 +0000 (21:46 +0800)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 13 Jan 2026 19:18:34 +0000 (11:18 -0800)
The commit 5f6df173f92e ("ice: implement and use rd32_poll_timeout for
ice_sq_done timeout") converted ICE_CTL_Q_SQ_CMD_TIMEOUT from jiffies
to microseconds.

But the ice_release_res() function was missed, and its logic still
treats ICE_CTL_Q_SQ_CMD_TIMEOUT as a jiffies value.

So correct the issue by usecs_to_jiffies().

Found by inspection of the DDP downloading process.
Compile and modprobe tested only.

Fixes: 5f6df173f92e ("ice: implement and use rd32_poll_timeout for ice_sq_done timeout")
Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_common.c

index 046bc9c65c51f4c108f2beadb65804c8abd529e5..785bf5cc1b25ec34fc183154052cab885d04b6a1 100644 (file)
@@ -2251,7 +2251,7 @@ void ice_release_res(struct ice_hw *hw, enum ice_aq_res_ids res)
        /* there are some rare cases when trying to release the resource
         * results in an admin queue timeout, so handle them correctly
         */
-       timeout = jiffies + 10 * ICE_CTL_Q_SQ_CMD_TIMEOUT;
+       timeout = jiffies + 10 * usecs_to_jiffies(ICE_CTL_Q_SQ_CMD_TIMEOUT);
        do {
                status = ice_aq_release_res(hw, res, 0, NULL);
                if (status != -EIO)