]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] gh-142048: Fix lost gc allocations count on thread cleanup (GH-142233) (#142504)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 10 Dec 2025 10:52:55 +0000 (11:52 +0100)
committerGitHub <noreply@github.com>
Wed, 10 Dec 2025 10:52:55 +0000 (10:52 +0000)
gh-142048: Fix lost gc allocations count on thread cleanup (GH-142233)
(cherry picked from commit 49b1fb43f65290dadeb83ed6f7c0c74995fda7a1)

Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Python/pystate.c

index 6781920b9eec66115886440a8b66ef9ce6833168..7188e5bf361fa59e20722d52a4139a0d1b64525f 100644 (file)
@@ -1815,16 +1815,23 @@ PyThreadState_Clear(PyThreadState *tstate)
     struct _Py_freelists *freelists = _Py_freelists_GET();
     _PyObject_ClearFreeLists(freelists, 1);
 
+    // Flush the thread's local GC allocation count to the global count
+    // before the thread state is cleared, otherwise the count is lost.
+    _PyThreadStateImpl *tstate_impl = (_PyThreadStateImpl *)tstate;
+    _Py_atomic_add_int(&tstate->interp->gc.young.count,
+                       (int)tstate_impl->gc.alloc_count);
+    tstate_impl->gc.alloc_count = 0;
+
     // Merge our thread-local refcounts into the type's own refcount and
     // free our local refcount array.
-    _PyObject_FinalizePerThreadRefcounts((_PyThreadStateImpl *)tstate);
+    _PyObject_FinalizePerThreadRefcounts(tstate_impl);
 
     // Remove ourself from the biased reference counting table of threads.
     _Py_brc_remove_thread(tstate);
 
     // Release our thread-local copies of the bytecode for reuse by another
     // thread
-    _Py_ClearTLBCIndex((_PyThreadStateImpl *)tstate);
+    _Py_ClearTLBCIndex(tstate_impl);
 #endif
 
     // Merge our queue of pointers to be freed into the interpreter queue.