]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dmaengine: ioatdma: make some sysfs structures static
authorThomas Weißschuh <linux@weissschuh.net>
Wed, 4 Mar 2026 21:44:37 +0000 (22:44 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 9 Mar 2026 07:28:21 +0000 (08:28 +0100)
These structures are only used in sysfs.c, where are defined.

Make them static and remove them from the header.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Link: https://patch.msgid.link/20260304-sysfs-const-ioat-v2-1-b9b82651219b@weissschuh.net
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ioat/dma.h
drivers/dma/ioat/sysfs.c

index 12a4a4860a74e90c1681d8810c6c3145dc0040ae..27d2b411853f71ec2623a5eacc8a2928a3a33b04 100644 (file)
@@ -195,9 +195,6 @@ struct ioat_ring_ent {
        struct ioat_sed_ent *sed;
 };
 
-extern const struct sysfs_ops ioat_sysfs_ops;
-extern struct ioat_sysfs_entry ioat_version_attr;
-extern struct ioat_sysfs_entry ioat_cap_attr;
 extern int ioat_pending_level;
 extern struct kobj_type ioat_ktype;
 extern struct kmem_cache *ioat_cache;
index 168adf28c5b136e50df57a12bd27c8d9ebab534a..5da9b0a7b2bbda50141e32c7f2b589ab4bf5a4c5 100644 (file)
@@ -26,7 +26,7 @@ static ssize_t cap_show(struct dma_chan *c, char *page)
                       dma_has_cap(DMA_INTERRUPT, dma->cap_mask) ? " intr" : "");
 
 }
-struct ioat_sysfs_entry ioat_cap_attr = __ATTR_RO(cap);
+static struct ioat_sysfs_entry ioat_cap_attr = __ATTR_RO(cap);
 
 static ssize_t version_show(struct dma_chan *c, char *page)
 {
@@ -36,7 +36,7 @@ static ssize_t version_show(struct dma_chan *c, char *page)
        return sprintf(page, "%d.%d\n",
                       ioat_dma->version >> 4, ioat_dma->version & 0xf);
 }
-struct ioat_sysfs_entry ioat_version_attr = __ATTR_RO(version);
+static struct ioat_sysfs_entry ioat_version_attr = __ATTR_RO(version);
 
 static ssize_t
 ioat_attr_show(struct kobject *kobj, struct attribute *attr, char *page)
@@ -67,7 +67,7 @@ const char *page, size_t count)
        return entry->store(&ioat_chan->dma_chan, page, count);
 }
 
-const struct sysfs_ops ioat_sysfs_ops = {
+static const struct sysfs_ops ioat_sysfs_ops = {
        .show   = ioat_attr_show,
        .store  = ioat_attr_store,
 };