]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
mod_proxy: Add comment and avoid ternary operator as condition (no functional change).
authorYann Ylavic <ylavic@apache.org>
Sat, 1 Mar 2014 21:36:27 +0000 (21:36 +0000)
committerYann Ylavic <ylavic@apache.org>
Sat, 1 Mar 2014 21:36:27 +0000 (21:36 +0000)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1573229 13f79535-47bb-0310-9956-ffa450edef68

modules/proxy/proxy_util.c

index 7fafbfdcf350a339e210d1adcd46d77120424c46..23dfba334b4c97ba39cea85e9e87910a75ced83c 100644 (file)
@@ -2367,10 +2367,14 @@ ap_proxy_determine_connection(apr_pool_t *p, request_rec *r,
         else {
             ssl_hostname = conn->hostname;
         }
-        if (conn->ssl_hostname != NULL
-                ? (ssl_hostname == NULL || strcasecmp(conn->ssl_hostname,
-                                                      ssl_hostname) != 0)
-                : (ssl_hostname != NULL && conn->sock)) {
+        /*
+         * Close if a SNI is in use but this request requires no or
+         * a different one, or no SNI is in use but one is required.
+         */
+        if ((conn->ssl_hostname && (!ssl_hostname ||
+                                    strcasecmp(conn->ssl_hostname,
+                                               ssl_hostname) != 0)) ||
+                (!conn->ssl_hostname && ssl_hostname && conn->sock)) {
             socket_cleanup(conn);
         }
         if (conn->ssl_hostname == NULL) {