Excluded Connection::rfc931 from cloning

This field can be classified as a 'value which cannot be reused across
(co-existing) Connection objects' (since it contains sensitive user
information which should not be leaked to other transactions).

diff --git a/src/comm/Connection.cc b/src/comm/Connection.cc
index 2fb964a8ca4a384deb8aabec4daa80779bc19c90..279b1c2f4a0991de54729d2332c99ab50cbe34d7 100644 (file)
--- a/src/comm/Connection.cc
+++ b/src/comm/Connection.cc
@@ -81,8 +81,7 @@ Comm::Connection::cloneProfile() const
     c.nfConnmark = nfConnmark;
     // COMM_ORPHANED is not a part of connection opening instructions
     c.flags = flags & ~COMM_ORPHANED;
-    if (*rfc931) // optimization
-        memcpy(c.rfc931, rfc931, sizeof(rfc931));
+    // rfc931 is excused
 
 #if USE_SQUID_EUI
     // These are currently only set when accepting connections and never used