]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.13] gh-142048: Fix quadratically increasing GC delays (gh-142051) (#142167)
authorSam Gross <colesbury@gmail.com>
Tue, 2 Dec 2025 00:31:36 +0000 (19:31 -0500)
committerGitHub <noreply@github.com>
Tue, 2 Dec 2025 00:31:36 +0000 (00:31 +0000)
The GC for the free threaded build would get slower with each collection due
to effectively double counting objects freed by the GC.
(cherry picked from commit eb892868b31322d7cf271bc25923e14b1f67ae38)

Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Misc/NEWS.d/next/Core and Builtins/2025-12-01-20-41-26.gh-issue-142048.c2YosX.rst [new file with mode: 0644]
Python/gc_free_threading.c

diff --git a/Misc/NEWS.d/next/Core and Builtins/2025-12-01-20-41-26.gh-issue-142048.c2YosX.rst b/Misc/NEWS.d/next/Core and Builtins/2025-12-01-20-41-26.gh-issue-142048.c2YosX.rst
new file mode 100644 (file)
index 0000000..1400dae
--- /dev/null
@@ -0,0 +1,2 @@
+Fix quadratically increasing garbage collection delays in free-threaded
+build.
index 6a38cc224a4bf88349e98dd5871983943ed5dec5..7c7e7b21e55a7d5c807b490bff5379a252b8cf17 100644 (file)
@@ -1100,7 +1100,19 @@ record_deallocation(PyThreadState *tstate)
     gc->alloc_count--;
     if (gc->alloc_count <= -LOCAL_ALLOC_COUNT_THRESHOLD) {
         GCState *gcstate = &tstate->interp->gc;
-        _Py_atomic_add_int(&gcstate->generations[0].count, (int)gc->alloc_count);
+        int count = _Py_atomic_load_int_relaxed(&gcstate->generations[0].count);
+        int new_count;
+        do {
+            if (count == 0) {
+                break;
+            }
+            new_count = count + (int)gc->alloc_count;
+            if (new_count < 0) {
+                new_count = 0;
+            }
+        } while (!_Py_atomic_compare_exchange_int(&gcstate->generations[0].count,
+                                                  &count,
+                                                  new_count));
         gc->alloc_count = 0;
     }
 }