]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rtc: m48t86: drop needless struct m48t86_rtc_info::rtc member
authorAndré Draszik <andre.draszik@linaro.org>
Tue, 4 Mar 2025 17:05:35 +0000 (17:05 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 5 Mar 2025 22:08:00 +0000 (23:08 +0100)
The memory pointed to by the ::rtc member is managed via devres, and
no code in this driver uses it past _probe().

We can drop it from the structure and just use a local temporary
variable, reducing runtime memory consumption by a few bytes.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-7-d4689a71668c@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-m48t86.c

index dd4a62e2d39c73b1c8c3f50a59fd4fffc0b45105..10cd054fe86f9e6be74eb282222b2751dd91cc7e 100644 (file)
@@ -41,7 +41,6 @@
 struct m48t86_rtc_info {
        void __iomem *index_reg;
        void __iomem *data_reg;
-       struct rtc_device *rtc;
 };
 
 static unsigned char m48t86_readb(struct device *dev, unsigned long addr)
@@ -219,6 +218,7 @@ static bool m48t86_verify_chip(struct platform_device *pdev)
 static int m48t86_rtc_probe(struct platform_device *pdev)
 {
        struct m48t86_rtc_info *info;
+       struct rtc_device *rtc;
        unsigned char reg;
        int err;
        struct nvmem_config m48t86_nvmem_cfg = {
@@ -250,17 +250,17 @@ static int m48t86_rtc_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       info->rtc = devm_rtc_allocate_device(&pdev->dev);
-       if (IS_ERR(info->rtc))
-               return PTR_ERR(info->rtc);
+       rtc = devm_rtc_allocate_device(&pdev->dev);
+       if (IS_ERR(rtc))
+               return PTR_ERR(rtc);
 
-       info->rtc->ops = &m48t86_rtc_ops;
+       rtc->ops = &m48t86_rtc_ops;
 
-       err = devm_rtc_register_device(info->rtc);
+       err = devm_rtc_register_device(rtc);
        if (err)
                return err;
 
-       devm_rtc_nvmem_register(info->rtc, &m48t86_nvmem_cfg);
+       devm_rtc_nvmem_register(rtc, &m48t86_nvmem_cfg);
 
        /* read battery status */
        reg = m48t86_readb(&pdev->dev, M48T86_D);