]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virStorageBackendISCSIDirectSetAuth: Use 'g_strndup' to '\0' terminate data
authorPeter Krempa <pkrempa@redhat.com>
Thu, 8 Dec 2022 10:12:54 +0000 (11:12 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 1 Feb 2023 08:16:17 +0000 (09:16 +0100)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/storage/storage_backend_iscsi_direct.c

index 63225c533ec3f4d129d49cb4777304b8d2a89863..ca906357c3d22fce520113c038c851259df576e4 100644 (file)
@@ -117,10 +117,8 @@ virStorageBackendISCSIDirectSetAuth(struct iscsi_context *iscsi,
                                  &secret_value, &secret_size) < 0)
         return -1;
 
-    secret_str = g_new0(char, secret_size + 1);
-    memcpy(secret_str, secret_value, secret_size);
+    secret_str = g_strndup((char *)secret_value, secret_size);
     virSecureErase(secret_value, secret_size);
-    secret_str[secret_size] = '\0';
 
     if (iscsi_set_initiator_username_pwd(iscsi,
                                          authdef->username, secret_str) < 0) {