ENH: Use modern cmake variable conventions

Use recommended naming conventions for variables

See https://cmake.org/cmake/help/v3.0/command/project.html?highlight=project for
the common conventions.

The project() command stores the version number and its components in variables

PROJECT_VERSION, <PROJECT-NAME>_VERSION
PROJECT_VERSION_MAJOR, <PROJECT-NAME>_VERSION_MAJOR
PROJECT_VERSION_MINOR, <PROJECT-NAME>_VERSION_MINOR
PROJECT_VERSION_PATCH, <PROJECT-NAME>_VERSION_PATCH
PROJECT_VERSION_TWEAK, <PROJECT-NAME>_VERSION_TWEAK

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 49acb1f4861b344f4c41fdbcf0d4b61dfbbfc1aa..b51f3f88f99e06557db88f861e7b3ddc1fef9a71 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -37,8 +37,6 @@ project(zlib
   VERSION ${ZLIB_HEADER_VERSION}
   LANGUAGES C)
 
-set(VERSION "${zlib_VERSION}")
-
 set(INSTALL_BIN_DIR "${CMAKE_INSTALL_PREFIX}/bin" CACHE PATH "Installation directory for executables")
 set(INSTALL_LIB_DIR "${CMAKE_INSTALL_PREFIX}/lib" CACHE PATH "Installation directory for libraries")
 set(INSTALL_INC_DIR "${CMAKE_INSTALL_PREFIX}/include" CACHE PATH "Installation directory for headers")

diff --git a/zlib.pc.cmakein b/zlib.pc.cmakein
index c0e4164d414941385a285bec9729d0ffcca2dfb5..0635b6e355dfe5698d33523fa11bd2ff62b559d8 100644 (file)
--- a/zlib.pc.cmakein
+++ b/zlib.pc.cmakein
@@ -6,7 +6,7 @@ includedir=@INSTALL_INC_DIR@
 
 Name: zlib@SUFFIX@
 Description: zlib-ng compression library
-Version: @VERSION@
+Version: @zlib_VERSION@
 
 Requires:
 Libs: -L${libdir} -L${sharedlibdir} -lz@SUFFIX@