upstream: Copy bytes from the_banana[] rather than banana()

Fixes test failure due to segfault seen on arm64 with xonly snap.

ok djm

OpenBSD-Regress-ID: 86e2aa4bbd1dff1bc4ebb2969c0d6474485be046

diff --git a/regress/unittests/sshkey/test_sshkey.c b/regress/unittests/sshkey/test_sshkey.c
index 982907ce7f0cc4d06b43030fce41007845cab3bc..cc359aea506332377c4f57fe9b03f178d549581c 100644 (file)
--- a/regress/unittests/sshkey/test_sshkey.c
+++ b/regress/unittests/sshkey/test_sshkey.c
@@ -1,4 +1,4 @@
-/*     $OpenBSD: test_sshkey.c,v 1.22 2021/12/14 21:25:27 deraadt Exp $ */
+/*     $OpenBSD: test_sshkey.c,v 1.23 2023/01/04 22:48:57 tb Exp $ */
 /*
  * Regress test for sshkey.h key management API
  *
@@ -144,7 +144,7 @@ banana(u_char *s, size_t l)
                        memcpy(s + o, "nanananana", l - o);
                        break;
                }
-               memcpy(s + o, banana, sizeof(the_banana));
+               memcpy(s + o, the_banana, sizeof(the_banana));
        }
 }