4384. [bug] isc_buffer_reallocate returns wrong result when passed

                        a smaller length than what is already allocated.
                        [RT #42612]

diff --git a/CHANGES b/CHANGES
index 4b8db33e571ce780258b77643d10436fc3c974ce..febcb80112322c81bb314a44361cd1cf32530845 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,7 @@
+4384.  [bug]           isc_buffer_reallocate returns wrong result when passed
+                       a smaller length than what is already allocated.
+                       [RT #42612]
+
 4383.  [bug]           Correct spelling error in stats channel description of
                        "EDNS client subnet option received". [RT #42633]
 

diff --git a/lib/isc/buffer.c b/lib/isc/buffer.c
index c8cbdd5a5dae0a224c21291d8c5dc3b28eb53713..751baf1fa6023a9e58b556839c5d73b5e0dabfff 100644 (file)
--- a/lib/isc/buffer.c
+++ b/lib/isc/buffer.c
@@ -523,7 +523,7 @@ isc_buffer_reallocate(isc_buffer_t **dynbuffer, unsigned int length) {
        REQUIRE((*dynbuffer)->mctx != NULL);
 
        if ((*dynbuffer)->length > length)
-               return (ISC_R_NOSPACE);
+               return (ISC_R_SUCCESS);
 
        /*
         * XXXMUKS: This is far more expensive than plain realloc() as