]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virSecurityLabelDefParseXML: Don't use virXMLPropStringLimit
authorPeter Krempa <pkrempa@redhat.com>
Mon, 22 Nov 2021 16:43:13 +0000 (17:43 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 24 Nov 2021 08:20:39 +0000 (09:20 +0100)
The function produces an error which is ignored in this code path.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_conf.c

index 13395a70235ac13b95a9434f5195c7e3dcc366f5..5cfb2d91eb779d74e06f37bca34060ebf9b3e0d9 100644 (file)
@@ -7804,8 +7804,9 @@ virSecurityLabelDefParseXML(xmlXPathContextPtr ctxt,
     g_autofree char *relabel = NULL;
     g_autoptr(virSecurityLabelDef) seclabel = NULL;
 
-    model = virXMLPropStringLimit(ctxt->node, "model",
-                                  VIR_SECURITY_MODEL_BUFLEN - 1);
+    if ((model = virXMLPropString(ctxt->node, "model")) &&
+        strlen(model) >= VIR_SECURITY_MODEL_BUFLEN - 1)
+        g_clear_pointer(&model, g_free);
 
     if (!(seclabel = virSecurityLabelDefNew(model)))
         return NULL;