netcmd: simplify boolean check

Should use "is" for checking booleans rather than "==" in Python, however these can also be simplified.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/python/samba/netcmd/domain/classicupgrade.py b/python/samba/netcmd/domain/classicupgrade.py
index 2ca4935d88d1e2f2c89ef0d5d2be1541d6133f84..4a8b90b5f2909272d6fc1e0cf3b508d15d0d5713 100644 (file)
--- a/python/samba/netcmd/domain/classicupgrade.py
+++ b/python/samba/netcmd/domain/classicupgrade.py
@@ -134,9 +134,9 @@ class cmd_domain_classicupgrade(Command):
         eadb = True
         if use_xattrs == "yes":
             eadb = False
-        elif use_xattrs == "auto" and use_ntvfs == False:
+        elif use_xattrs == "auto" and not use_ntvfs:
             eadb = False
-        elif use_ntvfs == False:
+        elif not use_ntvfs:
             raise CommandError("--use-xattrs=no requires --use-ntvfs (not supported for production use).  "
                                "Please re-run with --use-xattrs omitted.")
         elif use_xattrs == "auto" and not s3conf.get("posix:eadb"):