]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
[hsa] Fail in presence of atomic operations in private segment
authorMartin Jambor <mjambor@suse.cz>
Fri, 26 Feb 2016 17:39:11 +0000 (18:39 +0100)
committerMartin Jambor <jamborm@gcc.gnu.org>
Fri, 26 Feb 2016 17:39:11 +0000 (18:39 +0100)
2016-02-26  Martin Jambor  <mjambor@suse.cz>

* hsa-gen.c (gen_hsa_ternary_atomic_for_builtin): Fail in presence of
atomic operations in private segment.

From-SVN: r233748

gcc/ChangeLog
gcc/hsa-gen.c

index 7ce5fdcc2954ed8768fddd8bf36ea8f698e2e4a4..de2189a84078e82a7900130009d7e9a254f4c5d9 100644 (file)
@@ -1,3 +1,8 @@
+2016-02-26  Martin Jambor  <mjambor@suse.cz>
+
+       * hsa-gen.c (gen_hsa_ternary_atomic_for_builtin): Fail in presence of
+       atomic operations in private segment.
+
 2016-02-26  Martin Jambor  <mjambor@suse.cz>
 
        * omp-low.c (grid_find_ungridifiable_statement): Store problematic
index 8e2144c339a3a73557ddc08da4b1f6adfbb67354..7a7ec41ab8011124fc4331b408ca674287f570e4 100644 (file)
@@ -4557,8 +4557,13 @@ gen_hsa_ternary_atomic_for_builtin (bool ret_orig,
 
   hsa_op_address *addr;
   addr = get_address_from_value (gimple_call_arg (stmt, 0), hbb);
-  /* TODO: Warn if addr has private segment, because the finalizer will not
-     accept that (and it does not make much sense).  */
+  if (addr->m_symbol && addr->m_symbol->m_segment == BRIG_SEGMENT_PRIVATE)
+    {
+      HSA_SORRY_AT (gimple_location (stmt),
+                   "HSA does not implement atomic operations in private "
+                   "segment");
+      return;
+    }
   hsa_op_base *op = hsa_reg_or_immed_for_gimple_op (gimple_call_arg (stmt, 1),
                                                    hbb);