pinctrl: armada-37xx: propagate error from armada_37xx_gpio_get_direction()

[ Upstream commit 6481c0a83367b0672951ccc876fbae7ee37b594b ]

The regmap_read() function can fail, so propagate its error up to
the stack instead of silently ignoring that.

Signed-off-by: Imre Kaloz <kaloz@openwrt.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-6-07e9ac1ab737@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index e95d30ef5711b3b55ac5c51d34589999f1aa1872..3a9a3a1d5d4be731e5c77c48c8ab54d29f4ff625 100644 (file)
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -396,10 +396,13 @@ static int armada_37xx_gpio_get_direction(struct gpio_chip *chip,
        struct armada_37xx_pinctrl *info = gpiochip_get_data(chip);
        unsigned int reg = OUTPUT_EN;
        unsigned int val, mask;
+       int ret;
 
        armada_37xx_update_reg(&reg, &offset);
        mask = BIT(offset);
-       regmap_read(info->regmap, reg, &val);
+       ret = regmap_read(info->regmap, reg, &val);
+       if (ret)
+               return ret;
 
        if (val & mask)
                return GPIO_LINE_DIRECTION_OUT;