media: davinci: vpif: Fix memory leak in probe error path

If an error occurs during the initialization of `pdev_display`,
the allocated platform device `pdev_capture` is not released properly,
leading to a memory leak.

Adjust error path handling to fix the leak.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 43acb728bbc4 ("media: davinci: vpif: fix use-after-free on driver unbind")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Nikiforov <Dm1tryNk@yandex.ru>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/platform/ti/davinci/vpif.c b/drivers/media/platform/ti/davinci/vpif.c
index a81719702a22d18d6e0aede474144f0fd37a9105..969d623fc842e5b085196c86d51e58702dbe4fbb 100644 (file)
--- a/drivers/media/platform/ti/davinci/vpif.c
+++ b/drivers/media/platform/ti/davinci/vpif.c
@@ -504,7 +504,7 @@ static int vpif_probe(struct platform_device *pdev)
        pdev_display = kzalloc(sizeof(*pdev_display), GFP_KERNEL);
        if (!pdev_display) {
                ret = -ENOMEM;
-               goto err_put_pdev_capture;
+               goto err_del_pdev_capture;
        }
 
        pdev_display->name = "vpif_display";
@@ -527,6 +527,8 @@ static int vpif_probe(struct platform_device *pdev)
 
 err_put_pdev_display:
        platform_device_put(pdev_display);
+err_del_pdev_capture:
+       platform_device_del(pdev_capture);
 err_put_pdev_capture:
        platform_device_put(pdev_capture);
 err_put_rpm: