Fix mod_log_forensic bug by applying patch. reported *was* author

of patch, right??

PR:
Obtained from:
Submitted by:
Reviewed by:

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/1.3.x@104872 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/CHANGES b/src/CHANGES
index de864cdc857464657a8740beb8ef5fc0ba78b570..76304db174b2769e4b25d37fc8d0ade4a93b2a45 100644 (file)
--- a/src/CHANGES
+++ b/src/CHANGES
@@ -1,5 +1,9 @@
 Changes with Apache 1.3.32
 
+  *) Fix trivial bug in mod_log_forensic that caused the child
+     to seg fault when certain invalid requests were fired at it with
+     forensic logging is enabled. [Will Slater <Will Slater orbisuk.com>]
+
   *) Fix memory leak in the cache handling of mod_rewrite. PR 27862.
      [chunyan sheng <shengperson yahoo.com>, André Malo]
 

diff --git a/src/modules/standard/mod_log_forensic.c b/src/modules/standard/mod_log_forensic.c
index 4fc7ac772dd42607d57b22a0ec9d3f0eed1e8ba2..56cf33d5339fc029c5361d8126ee924aeb4679fe 100644 (file)
--- a/src/modules/standard/mod_log_forensic.c
+++ b/src/modules/standard/mod_log_forensic.c
@@ -233,6 +233,10 @@ static int log_after(request_rec *r)
         return DECLINED;
 
     rcfg = ap_get_module_config(r->request_config, &log_forensic_module);
+
+    if (!rcfg)
+        return DECLINED;
+
     s = ap_pstrcat(r->pool, "-", rcfg->id, "\n", NULL);
     write(cfg->fd, s, strlen(s));