Use $(uname -r) throughout

The backtick notation is considered deprecated, I believe. We already
have a handful of $(...) instances, so if nothing else it's better to
stay consistent.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/pull/416
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>

diff --git a/libkmod/libkmod.h b/libkmod/libkmod.h
index 1c0d1185dabd541c321f2ba7c5ae4d4ca251b240..3c60e961b08679a4273995aa223b9b3a615e0c15 100644 (file)
--- a/libkmod/libkmod.h
+++ b/libkmod/libkmod.h
@@ -34,7 +34,7 @@ struct kmod_ctx;
 /**
  * kmod_new:
  * @dirname: what to consider as linux module's directory, if NULL
- *           defaults to $MODULE_DIRECTORY/`uname -r`. If it's relative,
+ *           defaults to $MODULE_DIRECTORY/$(uname -r). If it's relative,
  *           it's treated as relative to the current working directory.
  *           Otherwise, give an absolute dirname.
  * @config_paths: ordered array of paths (directories or files) where

diff --git a/man/modprobe.8.scd b/man/modprobe.8.scd
index e397bde3d6032f33b6fe4bd673650b4a24452b52..8a4e0ffb1e5d47959ab8d405b57741df6e0f43e9 100644 (file)
--- a/man/modprobe.8.scd
+++ b/man/modprobe.8.scd
@@ -20,7 +20,7 @@ modprobe - Add and remove modules from the Linux Kernel
 *modprobe* intelligently adds or removes a module from the Linux kernel: note
 that for convenience, there is no difference between \_ and - in module names
 (automatic underscore conversion is performed). *modprobe* looks in the module
-directory @MODULE_DIRECTORY@/`uname -r` for all the modules and other files,
+directory @MODULE_DIRECTORY@/$(uname -r) for all the modules and other files,
 except for the optional configuration files (see *modprobe.d*(5)). *modprobe* will
 also use module options specified on the kernel command line in the form of
 <module>.<option> and blacklists in the form of modprobe.blacklist=<module>.

diff --git a/testsuite/testsuite.h b/testsuite/testsuite.h
index 4ce0c22cb55568f1ed08064792f0797d48bdfe34..c86e793b55e0b34573d52be666556dcc4be8aa57 100644 (file)
--- a/testsuite/testsuite.h
+++ b/testsuite/testsuite.h
@@ -22,7 +22,7 @@ enum test_config {
        TC_ROOTFS = 0,
 
        /*
-        * What's the desired string to be returned by `uname -r`. It will
+        * What's the desired string to be returned by $(uname -r). It will
         * trap calls to uname(3P) by LD_PRELOAD'ing uname.so and then filling
         * in the information in u.release.
         */

diff --git a/tools/modinfo.c b/tools/modinfo.c
index 75b574056aabae66095142cac691b19373f1311a..c1fd56b1fd08d9d4a7c3c465e2ef712615f631dd 100644 (file)
--- a/tools/modinfo.c
+++ b/tools/modinfo.c
@@ -336,7 +336,7 @@ static void help(void)
               "\t-0, --null                  Use \\0 instead of \\n\n"
               "\t-m, --modname               Handle argument as module name instead of alias or filename\n"
               "\t-F, --field FIELD           Print only provided FIELD\n"
-              "\t-k, --set-version VERSION   Use VERSION instead of `uname -r`\n"
+              "\t-k, --set-version VERSION   Use VERSION instead of $(uname -r)\n"
               "\t-b, --basedir DIR           Use DIR as filesystem root for " MODULE_DIRECTORY
               "\n"
               "\t-V, --version               Show version\n"

diff --git a/tools/modprobe.c b/tools/modprobe.c
index 349e7e0ef6b2cdf03bdf0c40bcf77881db0e1f4a..7a6c52902e2bee789a278b7c7534a7278f4f9eb5 100644 (file)
--- a/tools/modprobe.c
+++ b/tools/modprobe.c
@@ -128,7 +128,7 @@ static void help(void)
               "\t-C, --config FILE           Use FILE instead of default search paths\n"
               "\t-d, --dirname DIR           Use DIR as filesystem root for " MODULE_DIRECTORY
               "\n"
-              "\t-S, --set-version VERSION   Use VERSION instead of `uname -r`\n"
+              "\t-S, --set-version VERSION   Use VERSION instead of $(uname -r)\n"
 
               "\t-s, --syslog                print to syslog, not stderr\n"
               "\t-q, --quiet                 disable messages\n"