]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: make virDomainDiskDefFormatIotune() void
authorMatt Coleman <mcoleman@datto.com>
Fri, 6 Nov 2020 03:32:46 +0000 (22:32 -0500)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Nov 2020 11:53:11 +0000 (12:53 +0100)
This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 9b3e2a5bcb0a5685bec7f4c2a62084533da7454f..0cc385878b480f8e743b47f4329738e4ea94d64f 100644 (file)
@@ -25605,7 +25605,7 @@ virDomainDiskBackingStoreFormat(virBufferPtr buf,
                               disk->blkdeviotune.val); \
         }
 
-static int
+static void
 virDomainDiskDefFormatIotune(virBufferPtr buf,
                              virDomainDiskDefPtr disk)
 {
@@ -25643,8 +25643,6 @@ virDomainDiskDefFormatIotune(virBufferPtr buf,
     FORMAT_IOTUNE(write_iops_sec_max_length);
 
     virXMLFormatElement(buf, "iotune", NULL, &childBuf);
-
-    return 0;
 }
 
 #undef FORMAT_IOTUNE
@@ -25880,8 +25878,7 @@ virDomainDiskDefFormat(virBufferPtr buf,
     }
     virBufferAddLit(buf, "/>\n");
 
-    if (virDomainDiskDefFormatIotune(buf, def) < 0)
-        return -1;
+    virDomainDiskDefFormatIotune(buf, def);
 
     if (def->src->readonly)
         virBufferAddLit(buf, "<readonly/>\n");