virSecretLookupDefCopy: Remove return value

The function always returns succes so there's no need for a return
value.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/src/util/virsecret.c b/src/util/virsecret.c
index f44d964198c51d4c9b3e8f37d352479b153b85b5..54d6bbcb7cc384243e91c843bdb67202522fa88e 100644 (file)
--- a/src/util/virsecret.c
+++ b/src/util/virsecret.c
@@ -48,7 +48,7 @@ virSecretLookupDefClear(virSecretLookupTypeDefPtr def)
 }
 
 
-int
+void
 virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst,
                        const virSecretLookupTypeDef *src)
 {
@@ -58,7 +58,6 @@ virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst,
     } else if (dst->type == VIR_SECRET_LOOKUP_TYPE_USAGE) {
         dst->u.usage = g_strdup(src->u.usage);
     }
-    return 0;
 }
 
 

diff --git a/src/util/virsecret.h b/src/util/virsecret.h
index 8c49cfbc89a5c52fc0ce6a1e3eaa52ea73c2ff2b..cfdf2b6e29dba8bd4e50deead29281d71d13714d 100644 (file)
--- a/src/util/virsecret.h
+++ b/src/util/virsecret.h
@@ -48,8 +48,8 @@ struct _virSecretLookupTypeDef {
 };
 
 void virSecretLookupDefClear(virSecretLookupTypeDefPtr def);
-int virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst,
-                           const virSecretLookupTypeDef *src);
+void virSecretLookupDefCopy(virSecretLookupTypeDefPtr dst,
+                            const virSecretLookupTypeDef *src);
 int virSecretLookupParseSecret(xmlNodePtr secretnode,
                                virSecretLookupTypeDefPtr def);
 void virSecretLookupFormatSecret(virBufferPtr buf,

diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index 870c40f446644fd8d2628d522bfaf17f37bfa595..e723cc9410ff66f92517b5abc03f8d85b2474fe1 100644 (file)
--- a/src/util/virstoragefile.c
+++ b/src/util/virstoragefile.c
@@ -1792,8 +1792,7 @@ virStorageAuthDefCopy(const virStorageAuthDef *src)
     authdef->secrettype = g_strdup(src->secrettype);
     authdef->authType = src->authType;
 
-    if (virSecretLookupDefCopy(&authdef->seclookupdef, &src->seclookupdef) < 0)
-        return NULL;
+    virSecretLookupDefCopy(&authdef->seclookupdef, &src->seclookupdef);
 
     return g_steal_pointer(&authdef);
 }